Problem/Motivation

Fix broken test

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork videojs-3618098

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

anybody created an issue. See original summary.

anybody’s picture

Status: Active » Needs work

Still broken, I guess we need to debug the real HTML of the element at that moment.

grevil’s picture

Title: Fix broken test » [10.x] Fix broken test
grevil’s picture

I can't seem to replicate this behavior locally.... running the tests also succeed locally, no idea.

grevil’s picture

I already increased the timeout inside the original issue, but that also didn't result in anything really.

grevil’s picture

Ok all green now! Of course the tests fail if the library is missing...

But the cdn seems to be broken. I'll have a look at that quickly.

grevil’s picture

Assigned: grevil » Unassigned
Status: Needs work » Needs review

Ok cdn works as expected. No idea why it doesn't work with cdn and I already tried a lot.

I just updated the require-dev part to require the library via url. Please review!

thomas.frobieter’s picture

Status: Needs review » Reviewed & tested by the community
grevil’s picture

Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.