Problem/Motivation

The code references trash_entity_is_deleted() with its Trash integration however that API call has been deprecated in 3.0.30, and will be removed in 3.1.0

See https://www.drupal.org/node/3609675

Steps to reproduce

N/A

Proposed resolution

It should use the updated API where possible to avoid breaking sites that upgrade to the latest version.

Remaining tasks

Provide MR.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork entity_usage-3617877

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

codebymikey created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

This is fixed in the 5.x branch already. But I think doing some detection if \Drupal\trash\Trash::entityIsDeleted() exists and calling that in 8.x-2.x is a good idea.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review

Actually we can just go forward. Trash 3.0.30 is compatible with everything 8.x-2.x is so we can just add a conflict and use the new API.

alexpott opened merge request !238

  • alexpott committed 564a0b4a on 8.x-2.x 
    task: #3617877 trash_entity_is_deleted() is deprecated

By: codebymikey...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.