Problem/Motivation

I am trying to create some courses using LMS module. This problem is minor but confusing.

Steps to reproduce

  1. Go to a lesson edit page, like /admin/lms/lesson/2/edit
  2. Click on the Edit button next to an activity
  3. Click Cancel on the modal edit form.
  4. The page redirects to /admin/lms/activity

Proposed resolution

It should redirect back to where it came from, same as if you press the Escape key on the keyboard.

There is a workaround: Simply press the "<" or Back button on your browser.

Issue fork lms-3617749

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

leeksoup created an issue. See original summary.

leeksoup’s picture

leeksoup commented
Issue summary: View changes

graber made their first commit to this issue’s fork.

graber’s picture

graber commented
Version: 1.1.18 » 1.2.x-dev
Related issues: +#3588690: UI/UX: Add local tasks (View / Edit / Revisions tabs) on activity pages

Introduced in #3588690: UI/UX: Add local tasks (View / Edit / Revisions tabs) on activity pages.

graber opened merge request !201

  • graber committed 2560716d on 1.2.x 
    Resolve #3617749 "Cancel edit activity"
graber’s picture

graber commented
Status: Active » Fixed

We don't need that cancel button in a modal anyway, removed it.
Thank you for reporting!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.