Problem/Motivation

phpstan says,

Non-static method Drupal\Tests\taxonomy_machine_name\Kernel\Plugin\migrate\source\d7\TaxonomyMachineNameTermTest::providerSource() overrides static method Drupal\Tests\migrate\Kernel\MigrateSourceTestBase::providerSource().

Proposed resolution

Check whether the method is actually called anywhere in a non-static context, and if not, mark it as static to match the parent class.

API changes

In theory, third-party code could use the method in a non-static context, so that this change would break it. However, the parent method is static, so it was almost certainly an oversight that the child class wasn't also static.

Issue fork taxonomy_machine_name-3617727

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

benstallings created an issue. See original summary.

benstallings opened merge request !25

benstallings’s picture

benstallings commented
Assigned: benstallings » Unassigned
Status: Active » Needs review

dieterholvoet made their first commit to this issue’s fork.

dieterholvoet’s picture

dieterholvoet commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.