Problem/Motivation

Passing TRUE to write() here is redundant (it is the default value): https://git.drupalcode.org/project/drupal/-/blob/b6aadece5d777b6772d1bf8...

Steps to reproduce

Proposed resolution

Remove this argument.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3617668

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

prudloff created an issue. See original summary.

garvitasakhrani made their first commit to this issue’s fork.

garvitasakhrani opened merge request !16750

garvitasakhrani’s picture

garvitasakhrani commented
Status: Active » Needs review

Removed the redundant argument from HtaccessWriter::ensure() since TRUE is already the default value for write(). Updates have been pushed. Please review. Thanks!

smustgrave’s picture

smustgrave commented
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community

LGTM

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Backported to 11.x to keep things in sync but not a bug fix so not worth backporting further.

Committed and pushed fdcaa694054 to main and a7be8755f18 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed a7be8755 on 11.x 
    task: #3617668 Redundant argument in HtaccessWriter::ensure()

By:...

  • longwave committed fdcaa694 on main 
    task: #3617668 Redundant argument in HtaccessWriter::ensure()

By:...