Proposed resolution

  • Extract MyrestPriceBuilder behind an interface.
  • Decide with issue 62 whether the calculation helpers live here and are injected into the paragraph builder, or the reverse.
  • Add unit tests for the numeric parsing, which currently accepts arrays, comma decimal separators and raw strings without any coverage.

Remaining tasks

Coordinate the split with issue 62, then extract.

User interface changes

None.

API changes

New MyrestPriceBuilderInterface. Facade methods deprecated.

Issue fork myrest-3616674

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sergeydruua created an issue. See original summary.

sergeydruua opened merge request !62

  • sergeydruua committed bf5acb05 on 1.0.x 
    Issue #3616674: Extract the price builder out of the helper
sergeydruua’s picture

sergeydruua commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

sergeydruua’s picture

sergeydruua commented
Status: Fixed » Closed (fixed)