Problem/Motivation

The responsive video builder calls the provider derivative and poster methods directly, so one failing source breaks the rendering of the whole video and the page containing it. With providers now allowed to throw for invalid delivery URLs (#3616656: Invalid provider URLs can reach the rendered video markup), the builder needs per-source failure handling.

Steps to reproduce

  1. Configure a responsive video style whose provider throws while building a derivative or poster, for example because of an invalid stored delivery URL.
  2. Render the file: the exception escapes the builder and breaks the render.

Proposed resolution

Wrap the per-source derivative and poster building, log failures to a new responsive_video_style logger channel and skip the affected source or variant. The shared local fallback source keeps the video playable; a failed poster renders without a poster.

Remaining tasks

Review and merge the prepared fix.

User interface changes

None

API changes

ResponsiveVideoBuilder gains a logger as constructor dependency; new logger.channel.responsive_video_style service.

Data model changes

None

Comments

dpacassi created an issue. See original summary.

  • dpacassi committed 0398d6d6 on 1.0.x
    Issue #3616659 by dpacassi: A single failing provider derivative breaks...
dpacassi’s picture

Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.