CI's been red on 1.0.x for a while, checked properly today and it's every validate job: cspell, phpcs, phpstan.

phpcs - 11 violations, all in crwlr.install: 10 Drupal.Arrays.Array.LongLineDeclaration, 1 Drupal.Commenting.DocComment.ShortSingleLine. Easy to miss locally if you run phpcs without the right --extensions flag, since it'll silently skip .install files.

phpstan - 7 errors, all in src/CrawlTargetListBuilder.php around lines 33-35: direct entity storage injection instead of injecting EntityTypeManagerInterface, plus DependencySerializationTrait incompatible with private/readonly properties on PHP < 8.4.

cspell - a batch of technical/vendor terms never added to the project dictionary: disqualifier, epso, extractlinks, metacharacter, nodefdtd, noimplied, reencode, sitemapindex, spatie, uncast, unstarted, yoast, among others.

Issue fork crwlr-3615898

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nikro created an issue. See original summary.

nikro opened merge request !2

nikro’s picture

nikro commented
Assigned: nikro » abhisekmazumdar
Status: Active » Needs review

Pushed-in the branch -> please check. Lots of typos and standardizations here and there.

abhisekmazumdar’s picture

abhisekmazumdar
he/him
Primary language English
Location India
commented
Assigned: abhisekmazumdar » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks good

abhisekmazumdar’s picture

abhisekmazumdar
he/him
Primary language English
Location India
commented

I'm merging this because I need to make a dev release.

The last MR was merged into the `main` branch (my bad), so I cherry-picked it to `1.0.x`. I'm merging this issue as well.

@nikro, could you please remove `main` as the default branch? I don't have the required permissions.

abhisekmazumdar’s picture

abhisekmazumdar
he/him
Primary language English
Location India
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.