Problem/Motivation

In the installer, we update the kernel with installed themes, which rebuilds the container. But then more or less immediately after that, we discard that container anyway and rebuild it again Drupal\Tests\BrowserTestBase::initKernel

It should be possible to skip that step, probably only in the installer, which can easily take 1-2s for each method of each functional/functional js test.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3615878

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch opened merge request !16636

catch’s picture

catch
he/him
Primary language English
commented
Title: Don't bother rebulding the container after installing themes in the installer » Don't bother rebuilding the container after installing themes in the installer
catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

Added an optional argument to ThemeInstaller::install() which allows skipping the ::resetSystem() call, calling it only from the installer, tests are green.

nicxvan’s picture

nicxvan commented
Title: Don't bother rebuilding the container after installing themes in the installer » [pp-1] Don't bother rebuilding the container after installing themes in the installer
Status: Needs review » Postponed
Related issues: +#3594334: Add a module and theme install command

Let's postpone this on #3594334: Add a module and theme install command