Problem/Motivation

Current profile config storage for exclude_id is a string with line break.

  block_library:
    exclude_id: "system_menu_block:admin\r\nsystem_menu_block:devel\r\nsystem_clear_cache_block\r\nlocal_actions_block\r\n"

Proposed resolution

Convert from a string to a proper list, like what we did for the Pattern Preset sources in #3534190: Pattern presets storage and dependencies

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork display_builder-3615841

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mogtofu33 created an issue. See original summary.

pdureau made their first commit to this issue’s fork.

pdureau’s picture

pdureau commented
Assigned: Unassigned » pdureau

We are currently removing this logic from PatternPreset: #3618100: Pattern presets fix & clean-up

So, this is the good opportunity to adopt it in block_libraryand component_library islands storage.

pdureau opened merge request !365

pdureau’s picture

pdureau commented
Status: Active » Needs work

Work has started

mogtofu33’s picture

mogtofu33 commented
Issue tags: -display_builder-1.0.0-beta7 +display_builder-1.0.0-beta
pdureau’s picture

pdureau commented
Assigned: pdureau » mogtofu33
Status: Needs work » Needs review
mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » pdureau

Review fixes:

  • The post update is renamed to display_builder_post_update_exclude_id_as_list(). The numbered series is the frozen beta one, and new post updates are named after what they do. A post update is still the right place: a string under a sequence schema does not throw on save.
  • Removed the show key that the rebase re-added to the block_library schema. #3620380: Reduce permutations of library display options dropped it.
  • Reverted the unrelated display_builder.api.php change. It left the closing @} without its @{.
  • Added ProfileUpgradePathTest::testExcludeIdBecomesList(). The upgrade test only checked the schema, not the converted ids.
  • flattenFormValues() is now private, since contrib islands use the trait.
pdureau’s picture

pdureau commented
Assigned: pdureau » mogtofu33
Status: Needs review » Reviewed & tested by the community

The numbered series is the frozen beta one, and new post updates are named after what they do

It makes sense. Good to know.

Removed the show key that the rebase re-added to the block_library schema.

Oops, sorry. Rebase mistake.

flattenFormValues() is now private, since contrib islands use the trait.

OK

  • mogtofu33 committed 2967264e on 1.0.x authored by pdureau 
    task: #3615841 Config exclude_id array instead of string

By: mogtofu33...
mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » Unassigned
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.