#3615672: Read a row's seat order from the venue drawing, so a curved row stops claiming its two ends are adjacent merged with three allow_failure jobs red under a green pipeline badge. All three are in the code that issue added.

phpcs, 4 errors in VenueIoTest.php

  • Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps: testImportNumbersADrawnRowAlongItsDrawing. The sniff rejects two capitals in a row, and "ADrawn" has them. Renamed to testImportNumbersDrawnRowsAlongTheDrawing.
  • Drupal.Arrays.Array.LongLineDeclaration x 3: three manifest place rows written on one line each, at 166 columns against a limit of 120. Replaced by a drawnPlace() helper, which also stops the three rows repeating the same eight keys.

eslint, 1 error in venue-map-positions.js

no-use-before-define: overlay() calls toggle(), which is declared below it. Both venue-map.js and venue-map-pick.js already carry /* eslint-disable no-use-before-define */ with a comment explaining why: core's own eslint config sets the rule's functions option to false, and contrib CI falls back to the stricter default. The new file needed the same disable and comment.

cspell, 5 words

  • behaviours, neighbour, neighbours: British spelling, against the project's American spelling. Reworded, including widestNeighbours() to widestNeighbors().
  • undrawn, unwalked: invented words. Reworded to "a row with no drawing" and "nearest seat not yet walked", including the test method testAnUndrawnRowKeepsItsOrderAndClosesItsHoles.

Nothing is added to the project dictionary: every word is reworded instead.

Why the local runs missed them

Worth recording, because each miss has a different cause and each is avoidable.

  • phpcs: the two test methods were added after the last phpcs run, and it was not re-run.
  • eslint: run locally against the ci-templates config, which sets functions: false, so the error cannot appear. Checking it needs core's own config resolution, which is what CI uses.
  • cspell: not run locally at all. The project dictionary lives in .cspell-project-words.txt and the dictionaries the core config references resolve relative to web/core, so it has to be run from there.
  • All three are allow_failure, so the pipeline reported success with three jobs red. The badge cannot be trusted; every job has to be read.

No behaviour change: renames, rewordings, one comment and one test helper. RowPathTest, PlacePositionsTest and VenueIoTest stay green.

Issue fork yoyaku-3615686

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mably created an issue. See original summary.

  • mably committed 74362ff3 on 1.x
    task: #3615686 Fix the phpcs, eslint and cspell failures left by #...
mably’s picture

Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.