Problem/Motivation

We can save a couple of seconds from dozens of tests by moving the initial install of the module alongside the other test modules rather than installing it separately - avoids an additional container rebuild.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3615570

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Title: Optimize GenericTestBase » Optimize GenericModuleTestBase

catch opened merge request !16614

catch’s picture

catch
he/him
Primary language English
commented
Issue summary: View changes
catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
nicxvan’s picture

nicxvan commented
Status: Needs review » Reviewed & tested by the community

This is an easy one to review!

At first I thought you could remove the $this->getModule() call, but it's used further down a couple times.

catch’s picture

catch
he/him
Primary language English
commented

At first I thought you could remove the $this->getModule() call, but it's used further down a couple times.

Yes so did I!

  • godotislate committed f557e918 on 11.x 
    task: #3615570 Optimize GenericModuleTestBase

By: catch
By: nicxvan
(...

  • godotislate committed 7db0a117 on main 
    task: #3615570 Optimize GenericModuleTestBase

By: catch
By: nicxvan
godotislate’s picture

godotislate
he/him
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 7db0a11 to main and f557e91 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.