Problem/Motivation

MyrestRedirectEventSubscriber receives the messenger service. Messenger messages are queued into the session and later rendered on an unrelated HTML page, which is meaningless for API clients and can leak internal details to end users.

Proposed resolution

  • Replace messenger calls with a dedicated logger channel.
  • Remove the messenger argument from the service definition.

Remaining tasks

Refactor the subscriber and update myrest.services.yml.

User interface changes

API requests no longer queue status messages.

API changes

None.

Issue fork myrest-3615498

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sergeydruua created an issue. See original summary.

sergeydruua opened merge request !43

  • sergeydruua committed 4b372347 on 1.0.x 
    Issue #3615498: Remove Messenger usage from API request handling
sergeydruua’s picture

sergeydruua commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

sergeydruua’s picture

sergeydruua commented
Status: Fixed » Closed (fixed)