Problem/Motivation

To avoid duplicated calls to temp storage service and write operations, create a service that will abstract all of the operations.

Issue fork all_entity_preview-3615224

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

a.dmitriiev created an issue. See original summary.

a.dmitriiev opened merge request !14

a.dmitriiev’s picture

a.dmitriiev commented
Status: Active » Needs review

hanan alasari made their first commit to this issue’s fork.

hanan alasari’s picture

hanan alasari
Primary language English
Location kassel
commented
Assigned: Unassigned » hanan alasari
hanan alasari’s picture

hanan alasari
Primary language English
Location kassel
commented

Hi @artemd, I reviewed and tested the `PreviewStorage` service MR and pushed one follow-up commit to the same branch:

`788df20 Issue #3615224: Harden preview storage service API`

It keeps the refactor behavior-preserving, but adds a few small robustness/API improvements:

- invalid temp-store values and non-entity form states now return `NULL` instead of causing raw PHP errors
- the private temp-store collection is memoized inside the service
- `PreviewHooks::TEMPSTORE_NAME` is restored as a deprecated alias for backward compatibility
- `PreviewStorageInterface` was added for downstream integrations like Frontend Editing grouped save
- added coverage for set/get/delete, malformed values, non-entity forms, user isolation, and memoization

All relevant local tests passed.

hanan alasari’s picture

hanan alasari
Primary language English
Location kassel
commented
Status: Needs review » Reviewed & tested by the community
hanan alasari’s picture

hanan alasari
Primary language English
Location kassel
commented
Assigned: hanan alasari » Unassigned
a.dmitriiev’s picture

a.dmitriiev commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.