Problem/Motivation

Scanning the dev version of this module, php complains about multiple classes:

Direct injection of entity storage is not recommended. Inject Drupal\Core\Entity\EntityTypeManagerInterface and call getStorage() at the call-site instead.

Proposed resolution

Call getStorage() as requested.

Remaining tasks

I'm assigning this to myself while I work on it.

Issue fork entity-3615096

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

benstallings created an issue. See original summary.

benstallings opened merge request !53

benstallings’s picture

benstallings commented
Assigned: benstallings » Unassigned
Status: Active » Needs review
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Closed (duplicate)

Thanks, this was already fixed slightly differently in #3615092: missing CacheableMetadata parameter adn PHPStan errors. I tried to avoid changes of constructor parameters and services as this module is used quite heavily. Let me know if you still see issues!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.