Problem/Motivation

The CI pipeline currently isn't green. I think it would be great, if that could be accomplished.

Furthermore we might set 

phpcs:
  allow_failure: false
phpstan:
  allow_failure: false
cspell:
  allow_failure: false
...

etc. in gitlab-ci.yml where it makes sense, to that it's never allowed to make things worse again?

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork canvas_builder-3614970

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue tags: +Novice

yusuf_khan made their first commit to this issue’s fork.

yusuf_khan opened merge request !4

yusuf_khan’s picture

yusuf_khan commented
Status: Active » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

Thanks @yusuf_khan cspell, phpstan and stylelint are still a bit unhappy, see https://git.drupalcode.org/project/canvas_builder/-/merge_requests/4/rep...

Great work already! :)

aaronchristian’s picture

aaronchristian commented

Thanks for all your work everyone, i merged it and fixed the rest of the pipelines. Should be working well now.

I'm going to do some work on the tests and try to cut down the time it takes to run them. Appreciate the support.

aaronchristian’s picture

aaronchristian commented
Status: Needs work » Needs review
aaronchristian’s picture

aaronchristian commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

aaronchristian’s picture

aaronchristian commented
Status: Fixed » Closed (fixed)