Problem/Motivation

Shortcut module is being removed. Default Admin still references it.

Steps to reproduce

Proposed resolution

Remaining tasks

Review if we should only remove the comment indeed or also remove the styling.

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

LLM disclosure

LLM was used to identify this "dependency" on shortcut module. Fix was reviewed as a human though.

Issue fork drupal-3614946

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gábor hojtsy created an issue. See original summary.

gábor hojtsy opened merge request !16552

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue tags: +11.5.0 release priority
jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Assigned: Unassigned » mherchel

Thank you @gábor hojtsy. I'd say we should remove the entire comment if not the whole line. But also, that setting should certainly move into the shortcut module when that moves into its own project.

Assigning to @mherchel for him to decide what to do with this property.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented

Looks great, but I want to hold off on committing until #3606571: Round 2 of consolidating CSS Variables , which is very important and might possibly conflict with this.

smustgrave’s picture

smustgrave commented

Maybe this one could be committed since it's a small change and #3606571: Round 2 of consolidating CSS Variables be rebased since we don't know when that could be committed

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

For #7 consideration.

  • mherchel committed 513ff039 on main 
    task: #3614946 Remove very tiny mention of shortcut module from Default...
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 513ff039b4d to main. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.