Problem/Motivation

Modules specified in $modules currently get installed separately from modules in the install profile. This means two calls to ModuleInstaller::install() where it could be one instead.

Steps to reproduce

Proposed resolution

Add 'extra_modules' support to the installer, then set modules from the class property to that.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3614825

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch opened merge request !16539

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs work
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review

Fixed the last dozen or so remaining test failures.

Ended up adding default theme support to the installer too, since otherwise I think we'd have to rebuild the container whenever a non-stark theme is installed via the class property or similar. Doing this fixed all the tests using the starterkit theme via a class property.

A handful of test modules don't specify dependencies (because they were only ever installed after the module they depend on), so added those - straight bug in the test modules.

And a couple of other fixes which I've self-reviewed in the MR.

There is non-zero test fallout from this change but overall it's not very much in the scheme of things.

nicxvan’s picture

nicxvan commented

I think we need a CR here for the deprecation and we need to update the deprecation links.

I think a follow up for the core/modules/views/tests/src/Functional/Plugin/NumericFormatPluralTest.php rebuild is probably enough, I suspect your suspicion is correct and it's probably in a test module.

catch’s picture

catch
he/him
Primary language English
commented

Added a CR here: https://www.drupal.org/node/3616201

catch’s picture

catch
he/him
Primary language English
commented

Updated the deprecations to point to the CR. Also opened #3616202: Remove ::rebuildContainer() call in NumericFormatPluralTest.

catch’s picture

catch
he/him
Primary language English
commented

Cherry-picked a commit from @mstrelan based on #3616202-5: Remove ::rebuildContainer() call in NumericFormatPluralTest, that's good to narrow down the workaround to the minimum.