Problem/Motivation

Look for a missing feature of CKEditor5 (example: table column and row header scopes finally allowed), follow the trail of issues and see it was finally added in April to CKEditor v48. Go to check which version Drupal has installed.

Steps to reproduce

Go to the Status report /admin/reports/status and search (ctrl+f) for "ckeditor". Nothing shows up.

Proposed resolution

Report current installed version of CKEditor5 on Drupal's status report page.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 ckeditor5_version.png14.55 KBchaitanyadessai

Issue fork drupal-3614730

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mlncn created an issue. See original summary.

chaitanyadessai made their first commit to this issue’s fork.

chaitanyadessai’s picture

Status: Active » Needs review
StatusFileSize
new14.55 KB

Please review MR.

smustgrave’s picture

Status: Needs review » Needs work

+1 for the feature but pipeline did not pass.

chaitanyadessai’s picture

Status: Needs work » Needs review

Please review.

gokulg’s picture

Status: Needs review » Reviewed & tested by the community

Tested the patch on Drupal 11.x (dev) .

Steps:
1. Verified that CKEditor 5 version is not shown on /admin/reports/status in the base branch.
2. Applied the patch from MR !16961 and rebuilt the site.
3. After applying the patch, CKEditor 5 version is displayed correctly in the status report.

Result:
- Issue is reproducible on 11.x
- Patch fixes the issue as expected

Additionally, the previously reported pipeline issue appears to have been addressed.

Marking as RTBC.

quietone’s picture

Checking that the core gates are passed.

This issue is changing the UI so there should be before and after screen shots in the issue summary, where reviewers and committers can find them.

@gokulg, thanks for manually testing this change. In the future, make sure to test on the version the MR is against. That will almost always be 'main', which is our development branch. Changes are fixed there first and then backported according to our policies. And for a UI change the testing should always include before/after screenshots. And those should be in the issue summary as mentioned.

There are no questions here as this is quite straitforward.

I do have a question. Who is this information for? I don't see how it helps a site admin and a developer should be able to find this out via other means. And if we report on one dependency in the status report, what over the others. Is this setting an expectation?

xjm’s picture

One of the pieces of UX feedback we have had to address for this page several times is that it shouldn't contain information that is inactionable for site owners. They can do something about the PHP version, or whether their files directory is protected, or etc., even if they have to file an issue with their HSP or whatever. OTOH they have no control over what version of CKE is shipped by core.

Additionally, who is the audience of this information? If it's for developers integrating CKE plugins, the source is a better place to look. And if people see a CKE version but not a jQuery version does that then add confusion? Etc.

I would want usability review on this addition for the above reasons. That also means we would need screenshots with more context than the current one.

This page is also very site-owner-facing, so if the usability team signs off, I'd also want a product +1 before adding it.

Thanks!