Problem/Motivation

https://git.drupalcode.org/issue/drupal-3583486/-/jobs/11292799#L574

✘ Layout builder ui
  ┐
  ├ Behat\Mink\Exception\ElementNotFoundException: Element matching css ".layout__region--second .block-system-powered-by-block" not found.
  │
  │ /builds/vendor/behat/mink/src/WebAssert.php:465
  │ /builds/core/modules/layout_builder/tests/src/FunctionalJavascript/LayoutBuilderTest.php:193
  ┴

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3614520

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kentr created an issue. See original summary.

velmir_taky made their first commit to this issue’s fork.

velmir_taky opened merge request !16521

velmir_taky’s picture

velmir_taky commented
Status: Active » Needs review

CI: the layout_builder FunctionalJavascript job (3/3) is green — testLayoutBuilderUi passes.

danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented
Priority: Critical » Normal
Status: Needs review » Needs work

It would be nice to rework these tests to use less JS, but thats an issue for another day. For now, this should work well enough. Just left some minor fedback on the MR.

Don't think this should be critical.

velmir_taky’s picture

velmir_taky commented
Status: Needs work » Needs review

Trimmed the docblock to a single summary line, thanks.

danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented

I think this can be RTBC. The comment could probably even just be "Saves the Layout", but I don't want to keep an issue delayed for a single comment in a test file.

danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented
Status: Needs review » Reviewed & tested by the community
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Needs work

Similar to #3614519: [random test failure] CKEditor5AllowedTagsTest::testFullHtml I think we should just inline the helper, it makes the test easier to read.

velmir_taky’s picture

velmir_taky commented
Status: Needs work » Needs review

Done, inlined the helper. Thanks!

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Feedback appears to be addressed here.

godotislate’s picture

godotislate
he/him
commented

Test passes 300x: https://git.drupalcode.org/issue/drupal-3614520/-/jobs/11360454

  • godotislate committed 359cb8f4 on 11.x 
    fix: #3614520 [random test failure] LayoutBuilderTest::...

  • godotislate committed d4cf531e on main 
    fix: #3614520 [random test failure] LayoutBuilderTest::...
godotislate’s picture

godotislate
he/him
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed d4cf531 to main and 359cb8f to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.