Problem/Motivation

PHPStan usually takes a bit longer than the other lint jobs, we can run it first.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3614490

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

catch opened merge request !16516

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

LGTM

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Needs work

Needs rebase due to other CI changes recently.

longwave-bot made their first commit to this issue’s fork.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Reviewed & tested by the community

Rebased and fixed the rules section, the change is so trivial I'm going to self-RTBC this.

mstrelan’s picture

mstrelan commented

I'm assuming the display on https://git.drupalcode.org/issue/drupal-3614490/-/pipelines/919368 is alphabetical and the runners kick off in the order listed in the yaml? Looking at the "queued" time for each jobs, they match the order in the yaml:

phpstan: 2 seconds
cspell: 3 seconds
phpcs: 4 seconds
eslint: 5 seconds

Compared to another random pipeline I see:

cspell: 1 seconds
phpcs: 2 seconds
phpstan: 2 seconds

So I guess this is working as intended. With such a small margin I'm guessing the point of this is if the runners are busy we can at least get started on phpstan while waiting for others to become available, is that correct?

catch’s picture

catch
he/him
Primary language English
commented

I'm assuming the display on https://git.drupalcode.org/issue/drupal-3614490/-/pipelines/919368 is alphabetical and the runners kick off in the order listed in the yaml?
..

With such a small margin I'm guessing the point of this is if the runners are busy we can at least get started on phpstan while waiting for others to become available, is that correct?

Yeah exactly, there can be small delays from either the gitlab queues or kubernetes, since phpstan takes consistently longer we give it a potential head start, if/when everything starts at the same time then it doesn't make any difference.

We also use the same approach with test suites - at the moment build tests are the shortest so those start last (the rest constantly vary so are harder get an optimal order for).

  • mstrelan committed a1f8d1bb on 11.x 
    task: #3614490 Run PHPStan before cspell

By: catch
By: longwave
(cherry...

  • mstrelan committed 95fb376e on main 
    task: #3614490 Run PHPStan before cspell

By: catch
By: longwave
mstrelan’s picture

mstrelan commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed e5205613c6d to main and 3ac9b048ca9 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

mstrelan’s picture

mstrelan commented
Version: main » 11.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.