Problem/Motivation

Steps to reproduce

When mail_safety.settings keys are overridden via settings.php (the README-recommended way to enable Mail Safety per environment), the settings form gives no indication unlike core forms (e.g. Performance).

Proposed resolution

Migrate all form elements to #config_target, drop the redundant #default_value loading and the custom submitForm() (handled by the parent via the config-target map).

Remaining tasks

MR to be created.

User interface changes

A message will appear when config is overriden in settings.php.

API changes

None

Data model changes

None

Issue fork mail_safety-3614472

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tostinni created an issue. See original summary.

tostinni changed the visibility of the branch 2.x to hidden.

tostinni opened merge request !15

tostinni’s picture

tostinni commented
Title: Settings form doesn't indicate overridden values — migrate to #config_target » Settings form doesn't indicate overridden value, migrate to #config_target
Status: Active » Needs review

MR Submitted

sjerdo’s picture

sjerdo
Primary language Dutch
Location Haarlem
commented
Status: Needs review » Fixed

Thanks!

I'll update the core version requirement to ^10.2 to make sure we don't break older installations

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.