Problem/Motivation

Recent pipelines report phpstan issues

Steps to reproduce

See https://git.drupalcode.org/issue/mailchimp_transactional-3614210/-/jobs/...

Proposed resolution

Fix phpstan findings in recent pipelines

Remaining tasks

  1. Write a merge request
  2. Review
  3. Commit

User interface changes

None

API changes

None

Data model changes

None

Issue fork mailchimp_transactional-3614214

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented

Note that fixed for these findings are also included in #3599907: Automated Drupal 12 compatibility fixes for mailchimp_transactional 1.0.x-dev, but those changes requires a minimum Core version of 10.1 to include the DeprecationHelper, see https://www.drupal.org/node/3379306

velmir_taky made their first commit to this issue’s fork.

velmir_taky opened merge request !44

velmir_taky’s picture

velmir_taky commented
Status: Active » Needs review

Done!
Pipeline's green.

dieterholvoet’s picture

dieterholvoet commented
Status: Needs review » Needs work

Left some comments in the MR.

velmir_taky’s picture

velmir_taky commented

Thanks for looking, @dieterholvoet! I can't find any comments on MR !44 though - the Overview shows no threads and I'm the only participant, so I suspect they're still pending/unsubmitted on your side. Could you post them? Happy to address everything once I can see them.

velmir_taky’s picture

velmir_taky commented
Status: Needs work » Needs review
dieterholvoet’s picture

dieterholvoet commented
Status: Needs review » Needs work

My bad, forgot to submit them.

velmir_taky’s picture

velmir_taky commented
Status: Needs work » Needs review
dieterholvoet’s picture

dieterholvoet commented
Status: Needs review » Fixed

Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.