Problem/Motivation

After #3612952: Optimize GenerateThemeTest build tests should finish in ~2m30s and require less concurrency to finish in that time.

Steps to reproduce

Proposed resolution

We can do two things:

1. Move the tests to the end of the YAML so they run last - because it will be the quickest test group to finish now most of the time (other than unit tests which don't wait for the lint jobs to finish).

2. Cut the CPU request and concurrency by half because that should still be enough for the tests to finish in the same time.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3613745

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Title: Reduce CPU request for build tests » [PP-1] Reduce CPU request for build tests
Issue summary: View changes
Status: Active » Postponed

Postponing on #3612952: Optimize GenerateThemeTest because that's a remaining very slow build test, but that's RTBC and all the other main blockers to this issue have landed I think.

catch opened merge request !16477

catch’s picture

catch
he/him
Primary language English
commented
Title: [PP-1] Reduce CPU request for build tests » Reduce CPU request for build tests and run them last
Status: Postponed » Needs review

Going by https://git.drupalcode.org/project/drupal/-/jobs/11221595 this is already finishing before the other test groups, so doesn't actually need to be postponed.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Say lets try it some and see. Been my approach with some gitlab changes on both Drupal and work lol

catch’s picture

catch
he/him
Primary language English
commented

Rebased after https://git.drupalcode.org/project/drupal/-/jobs/11239035 and tests finished in 2 minutes with 4 concurrency/8cpu which is a full minute or more shorter than most other test jobs so we should be good here.

catch’s picture

catch
he/him
Primary language English
commented

Noticed a couple more things, last run the tests themselves took 1m47s https://git.drupalcode.org/project/drupal/-/jobs/11240027 entire job finished in 2m35s. This doesn't leave much leeway when we re-enable the package_manager tests or add new slow tests but we can increase concurrency again then if we need it. Leaving RTBC because this is just moving #slow around a bit.

  • longwave committed f7f3b939 on main 
    test: #3613745 Reduce CPU request for build tests and run them last

By...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed f7f3b93913b to main. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.