#3613729: Split the overloaded result vocabulary into the outcome and the completion payload splits orchestra's overloaded result vocabulary into
the outcome (the resolved decision a flow condition routes on) and the
completion payload (whatever complete() was called with). The node
config keys and one engine method yoyaku uses move with it, so yoyaku has to
follow or its shipped example workflow stops binding its steps.

  • result_variable becomes payload_variable and
    result_scope becomes completion_scope, in
    yoyaku_orchestra_example's yoyaku_booking workflow
    (both the node config and the BPMN XML it embeds) and in the kernel tests that
    build workflows inline.
  • ProcessControlInterface::resumeWithResult() becomes
    resumeWithPayload(), called by
    BookingProcessCorrelator and one functional test; the
    correlator's own $result parameters become $payload
    to match, and its interface documentation with them.
  • The example variable names that hold a scalar outcome are renamed for the
    same reason the upstream ones were: cancel_result,
    cancel_order_result, confirm_result,
    form_result, payment_result,
    release_result, settle_result and
    yoyaku_deposit_result become *_outcome.

Pre-release, so no update hooks: a site's saved workflows and any process
variable holding a payload under the old key are rewritten by hand.

Issue fork yoyaku-3613738

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mably created an issue. See original summary.

mably’s picture

Status: Active » Needs work
mably’s picture

Status: Needs work » Needs review

  • mably committed d002d6ba on 1.x
    task: #3613738 Follow orchestra's result vocabulary split: payload...
mably’s picture

Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.