Problem/Motivation

I tried tagging 1.6 but the phpunit job is failing so we should fix that before creating the release: https://git.drupalcode.org/project/config_override_warn/-/jobs/11195892

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork config_override_warn-3613444

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

prudloff created an issue. See original summary.

prudloff’s picture

prudloff commented

The failing tests are using SiteInformationForm.
Since #1503146: Aliased paths cannot be set as front page, this form does not have getEditableConfigNames() anymore. (But it uses #config_target so it works with core's warning: #3462541: Difference with what is now in core?)

I see two possible solutions:

  • Support #config_target (but then the form will have two different warnings).
  • Stop using this form in tests.

velmir_taky made their first commit to this issue’s fork.

velmir_taky opened merge request !11

velmir_taky’s picture

velmir_taky commented
Status: Active » Needs review

The failure comes from core #1503146: SiteInformationForm dropped its own getEditableConfigNames() and now uses RedundantEditableConfigNamesTrait, which returns []. So FormOverrides finds no config names for it and the four system.site data sets in FormOverridesTest fail (Tests: 9, Failures: 4, "Actual: Array &0 []") — matching the job on 11.4.4.

Went with option 2 (stop using that core form in the test). Added a small TestSiteInformationForm (ConfigFormBase, getEditableConfigNames() returns ['system.site']) in the test namespace and pointed the data provider at it.
Same code path, decoupled from core form changes. No module code change — supporting #config_target would duplicate core's own warning (#3462541).

velmir_taky’s picture

velmir_taky commented
Related issues: +#1503146: Aliased paths cannot be set as front page, +#3462541: Difference with what is now in core?

prudloff’s picture

prudloff commented
Status: Needs review » Fixed

Looks good, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.