Needs review
Project:
Antibot
Version:
2.0.5
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
27 Jul 2026 at 13:12 UTC
Updated:
18 Aug 2026 at 22:00 UTC
Jump to comment: Most recent, Most recent file
The sync code introduced in #3460684 in antibot_form_alter() for webform_settings_form has two issues:
webform_submission_*_add_form IDs to antibot.settings one-by-one on each webform save, instead of managing the webform_submission_* wildcard when the Webform module's global "Protect all webforms" third-party setting is enabled. This causes dirty config on every drush cex.webform_settings_form (per-webform settings). When the global "Protect all webforms" option is toggled at /admin/structure/webform/config (form_id: webform_admin_config_forms_form), the wildcard is never added or removed from antibot.settings./admin/structure/webform/config and enable "Protect all webforms with Antibot".antibot.settings form_ids — the webform_submission_* wildcard is never added.webform_submission_*_add_form ID is added instead of the wildcard.Fix the sync logic in antibot_form_alter() to properly handle the Webform module's global "Protect all webforms" setting:
webform_admin_config_forms_form (the form at /admin/structure/webform/config), so the wildcard is synced when the user toggles the global "Protect all webforms" option.webform.third_party_settings_manager), ensure the webform_submission_* wildcard is present in form_ids instead of adding individual webform_submission_*_add_form IDs one by one.form_ids if present, and sync individual webform IDs only on the per-webform settings form (webform_settings_form).Note: This issue is related to a companion Webform patch that fixes the Antibot third-party checkbox UI when global protection is active. See related Webform issue #3613417.
None.
None.
None. The patch only changes how antibot.settings form_ids are managed at save time.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | sync-wildcard-3613411-1.patch | 3.4 KB | solucionex |
Comments
Comment #2
solucionex commentedComment #3
solucionex commentedComment #4
solucionex commentedComment #5
cao89 commentedAny chance of this getting reviewed and merged in any time soon? I had to pin to 2.0.4 because it was causing an issue with a config read only ignore setting. Basically we allow content admins to change settings to webforms but not others and I think this issue is causing can a fatal error when they try to adjust webform settings.
Comment #6
danrodI'll look into merging to the 2.0.x branch and create a tagged release