Problem/Motivation

QuotaManager::getDashboardData() and RollupManager::getMonthAggregates() duplicate the same joins, quota-percentage expression, and sort/ORDER BY logic across two classes. Issue #3613214 needed the same ORDER BY fix in both places and missed one on the first pass, because nothing keeps them in sync.

Proposed resolution

Extract the shared joins, quota-percentage expression, and sort resolution into one place both classes use. Each method keeps its own table-specific aggregation (raw log vs pre-aggregated rollup).

AI assistance

Yes.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

codeitwisely created an issue. See original summary.

  • c8f2338d committed on 1.0.x
    Issue #3613258 by codeitwisely: Extract shared per-user dashboard sort...
codeitwisely’s picture

Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

codeitwisely’s picture

Status: Fixed » Closed (fixed)