Problem/Motivation

When saving config, checking config schema creates thousands of typed data objects, we can skip some of that by re-using un-replaced definitions - saves about 2,000 calls to ::getDefinition() for each method in FieldResolverTest

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 Screenshot from 2026-07-26 12-24-19.png451.47 KBcatch
#4 Screenshot from 2026-07-26 12-24-14.png439.32 KBcatch

Issue fork drupal-3613256

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

catch opened merge request !16448

catch’s picture

catch
he/him
Primary language English
commented
StatusFileSize
new Screenshot from 2026-07-26 12-24-14.png439.32 KB
new Screenshot from 2026-07-26 12-24-19.png451.47 KB

Adding before/after xhprof screenshots - looks like about 40ms out of 250ms saved.

catch’s picture

catch
he/him
Primary language English
commented

FieldResolverTest is consistently the last test to finish in HEAD afaict, in https://git.drupalcode.org/project/drupal/-/jobs/11172674 it finishes quite a way before the end. This is when combined with #3585986: Remove remaining key/value implementation from the entity field map and supporting code

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

godotislate’s picture

godotislate
he/him
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 57faef3 to main and c28ed37 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.