The booking workflow classified an empty order as free at a separate n_route gateway, so an emptied basket routed to Place Order and dead-lettered. Now that the payment step can route on a resolver outcome (see #3613222: Let the payment step route on a resolver outcome (pay, no_payment, empty)), the booking resolver classifies the run and the route gateway is removed.

Changes:

  • BookingPayableResolver::routeOutcome(): empty when there is no order or no representing lines, pay when a charge or a card on file is due, no_payment when there are lines but nothing to collect.
  • Example workflow config: drop n_route and its two flows, point the submitted flow at the payment step, add a no_payment flow to Place Order, and set the empty message.
  • French translation of the empty message, and a kernel test, BookingRouteOutcomeTest.

Builds on the orchestra route outcome contract in #3613222: Let the payment step route on a resolver outcome (pay, no_payment, empty).

Issue fork yoyaku-3613223

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mably created an issue. See original summary.

mably opened merge request !96

mably’s picture

mably commented
Status: Active » Needs review

  • mably committed bdf912e8 on 1.x 
    task: #3613223 Drop the n_route gateway; let the payment step route the...
mably’s picture

mably commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.