Problem/Motivation

Top three slowest functional tests. It's only got three methods, two of them are over a minute each because the keep uninstalling and installing modules. So the easiest thing is to split one of them out to its own class.

 171.070s Drupal\Tests\system\Functional\Module\NonStableModulesTest                3 passed

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3613162

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch opened merge request !16437

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

As with all of these differences between gitlab runners make comparison hard, but encouraging anyway:

 38.112s Drupal\Tests\system\Functional\Module\NonStableModulesTest                2 passed

https://git.drupalcode.org/project/drupal/-/jobs/11159050

  35.075s Drupal\Tests\system\Functional\Module\DeprecatedModulesTest               1 passed

https://git.drupalcode.org/project/drupal/-/jobs/11159049

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems like a good split. 3 seconds seems hard to notice but get enough of them it adds up I'm sure.

catch’s picture

catch
he/him
Primary language English
commented

Just for the record it's 171s down to 38s + 32s. Although the individual tests should probably add back up to 171s if they were in the same machine. But it means this test won't run past the end of all the other tests that have already finished.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed e5601044b24 to main. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed e5601044 on main 
    test: #3613162 Split up NonStableModulesTest

By: catch