Problem/Motivation

https://git.drupalcode.org/project/drupal/-/jobs/11157964/viewer

 ✔ Delete all
 ✘ Create directory fail warning
   ┐
   ├ Failed asserting that 'file_put_contents(): Failed to open stream: "org\bovigo\vfs\vfsStreamWrapper::stream_open" call failed' starts with "file_put_contents(vfs://permissionDenied/test/subdirectory/foo.php)".
   │
   │ /builds/core/tests/Drupal/Tests/Component/PhpStorage/FileStorageTest.php:112
   ┴

Steps to reproduce

Proposed resolution

Looks like we need to make the assertion more permissive or conditional on the PHP version.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3613160

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

mondrake made their first commit to this issue’s fork.

mondrake opened merge request !16474

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
godotislate’s picture

godotislate
he/him
commented
Status: Needs review » Reviewed & tested by the community

8.5 error message is file_put_contents(vfs://permissionDenied/test/subdirectory/foo.php): Failed to open stream: "org\bovigo\vfs\vfsStreamWrapper::stream_open" call failed
8.6 error message is file_put_contents(): Failed to open stream: "org\bovigo\vfs\vfsStreamWrapper::stream_open" call failed' starts with "file_put_contents(vfs://permissionDenied/test/subdirectory/foo.php)" (per IS)

MR uses regexp match with pattern /file_put_contents(.*): Failed to open stream: ".*vfsStreamWrapper::stream_open" call failed

lgtm

  • catch committed 62fd74c6 on 11.x 
    fix: #3613160 PHP 8.6 failure in FileStorageTest

By: catch
By: mondrake...

  • catch committed 0439c440 on main 
    fix: #3613160 PHP 8.6 failure in FileStorageTest

By: catch
By: mondrake...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, 11.x, and 11.4.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed abdd113c on 11.4.x 
    fix: #3613160 PHP 8.6 failure in FileStorageTest

By: catch
By: mondrake...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.