The Slots overview "Categories" column renders each tier as "confirmed / held / free", but it computes free as capacity minus confirmed minus held only. Bookings in the completed (checked in) and unused (settled no-show) states are also consuming states, so they were neither shown nor subtracted from free.

Effect: as confirmed holders are checked in at the door their places are handed back to free, so a full tier can read as available and the confirmed count understates real occupancy. The booking engine is correct (BookingManager::boundedAvailability subtracts every consuming state); only this overview re-implemented the sum and dropped two states.

Fix: subtract all four consuming states from capacity, and surface a "checked in" and, when present, an "unused" count in the cell, for example "1 confirmed - 1 checked in - 1 held - 2 free". Adds a functional test asserting a checked-in booking still occupies its place.

Issue fork yoyaku-3613133

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mably created an issue. See original summary.

mably opened merge request !91

mably’s picture

mably commented
Status: Active » Needs review

  • mably committed 9a12f19b on 1.x 
    fix: #3613133 Slot categories overview overstates free places by...
mably’s picture

mably commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.