Problem/Motivation

Follow up to #3607061: Don't spellcheck composer.json

In that issue, cspell config was updated so changes to composer.json files wouldn't cause failed builds. We removed some dictionary words that we no longer needed, but that caused cspell to fail in backport branches, as they still needed those words.

No one wants a backport to fail because of cspell. The spelling has already been checked when pipeline ran against main. It's a waste of develop time, and CI minutes.

Steps to reproduce

Proposed resolution

The simple approach is to just remove the cspell job from 11.x and 11.4.x, but that is not future proof. Instead we can take the same approach as #3580398: Skip on-commit jobs for the main and 11.x branches and add a condition on the job.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3612933

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mstrelan created an issue. See original summary.

mstrelan’s picture

mstrelan commented
Related issues: +#3607061: Don't spellcheck composer.json

mstrelan opened merge request !16421

mstrelan opened merge request !16422

mstrelan’s picture

mstrelan commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Makes sense, would love to see be able to automatically check for old words that don't need to be there. Like a warning, not failure, that words that can be removed are still there. But not sure if that's possible? Just speaking out loud. Know quietone will occasionally will update the dictionary of stale words.

  • longwave committed dfd362ce on 11.x 
    ci: #3612933 Only run cspell on main and MRs that target main

By:...

  • longwave committed f7307570 on main 
    ci: #3612933 Only run cspell on main and MRs that target main

By:...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

I think we could re-output the dictionary files like we do with phpstan, then people can redownload them if they want? But none of this spelling stuff is critical really, although it's still good at catching silly typos.

Committed and pushed f7307570b3b to main and dfd362cef4e to 11.x. Thanks!

This could be backported further but not sure it's worth it now.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.