Great module, beautifully simple!

One point to note is that I believe that any Content types which cannot be trashed—i.e. those NOT selected on the configuration page should probably not appear as filterable items on the Trash page itself…

trash_module_disabled_content_types_should_not_appear_as_filterable_types_in_trash_page

CommentFileSizeAuthor
trash_module_disabled_content_types_should_not_appear_as_filterable_types_in_trash_page.png99.65 KBsirclickalot

Issue fork trash-3612536

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sirclickalot created an issue. See original summary.

amateescu made their first commit to this issue’s fork.

amateescu opened merge request !144

amateescu’s picture

amateescu commented
Status: Active » Needs review

Nice suggestion, and easy to fix too :)

  • amateescu committed 520fa65d on 3.1.x 
    feat: #3612536 Content types disabled in config page should not appear...

  • amateescu committed 847f5a93 on 3.x 
    feat: #3612536 Content types disabled in config page should not appear...
amateescu’s picture

amateescu commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

sirclickalot’s picture

sirclickalot
Primary language English
Location Somerset, UK
commented

I can confirm that 144.patch from https://git.drupalcode.org/project/trash/-/merge_requests/144 fixes the issue nicely for me after cache clear.

Excellent, thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.