\Drupal\Tests\workspaces\Functional\WorkspaceTestUtilities::createNodeThroughUi exists to test creating nodes by clicking buttons. There may be instances where this is worth testing in the workspaces context, but doing this in a for loop 50 times is excessive and wasteful.
$ grep -r createNodeThroughUi core/modules/workspaces
Convert all of them to use $this->drupalCreateNode().
Add one explicit test to verify nodes created via the UI when a workspace is active is assigned to that workspace.
Consider doing the same for \Drupal\Tests\workspaces\Functional\WorkspaceTestUtilities::createAndActivateWorkspaceThroughUi
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !16385
Comments
Comment #3
mstrelan commentedHere's a start, feel free to pick this up and convert the rest.
Comment #4
mstrelan commentedComment #5
mstrelan commentedComment #6
smustgrave commentedRan the grep provided $ grep -r createNodeThroughUi core/modules/workspaces
core/modules/workspaces/tests/src/Functional/WorkspaceTestUtilities.php: protected function createNodeThroughUi($label, string $bundle, $publish = TRUE) {
core/modules/workspaces/tests/src/Functional/WorkspaceTest.php: $node = $this->createNodeThroughUi('Test', 'test');
So seems you got all instances, unless I'm missing something.
May be a follow up but do we "want" a createNodeThroughUi function? May be worth dropping.
Comment #7
mstrelan commentedI replaced all instances, but added a new instance, because I believe there is some merit in explicitly testing this, and all existing instances were implicit.
Comment #10
amateescu commentedCommitted and pushed f668443b84d to main and 3408229e85d to 11.x. Thanks!