The order operations (OrderOperationsTrait::orderOperationLinks) offer a Cancel link on any order that is not already cancelled and not archived. That still includes completed and no-show (unused) orders.

Since #3611922, cancelTransaction() refuses a settled order (completed, unused) or an already-cancelled one, returning without a change. So on those orders the Cancel link leads to the confirm screen and then does nothing: a dead control.

Fix: offer Cancel only while the order has not settled (the trait already computes a "settled" flag covering cancelled, completed and unused), matching the manager guard. Should have been folded into #3611922. Kernel-tested.

Issue fork yoyaku-3611952

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mably created an issue. See original summary.

mably opened merge request !58

  • mably committed f3156cbe on 1.x 
    fix: #3611952 Cancel is offered on a settled order, where cancelling...
mably’s picture

mably commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.