Problem/Motivation

Toolbar is scheduled to be deprecated and removed. Tests installing the Toolbar module outside of the Toolbar module need to be changed.

Steps to reproduce

Proposed resolution

Remove Toolbar from tests where it isn't needed.

  • core/modules/announcements_feed/tests/src/Functional/AnnouncementsCacheTest.php
  • core/modules/announcements_feed/tests/src/Kernel/AnnounceFetcherUserTest.php
  • core/modules/config_translation/tests/src/Functional/ConfigTranslationListUiTest.php
  • core/modules/shortcut/tests/src/Functional/ConfigTranslationListUiTest.php
  • core/modules/shortcut/tests/src/Kernel/ShortcutCacheTagsTest.php
  • core/modules/system/tests/src/Functional/Menu/MenuAccessTest.php
  • core/modules/views_ui/tests/src/Functional/DisplayPathTest.php

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3611749

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !16352

quietone’s picture

quietone commented
Title: Change tests using the Toolbar module » Remove toolbar from tests where it is not needed
Issue summary: View changes
quietone’s picture

quietone commented
Status: Active » Needs review
Issue tags: +11.5.0 priority
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Think the evidence is in the results. Tests still pass

quietone’s picture

quietone commented
Issue summary: View changes

  • longwave committed 5cd7e9c3 on main 
    test: #3611749 Remove toolbar from tests where it is not needed

By:...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed 5cd7e9c and pushed to main. Thanks!

Doesn't cherry-pick cleanly to 11.x, there is a conflict in AnnounceFetcherUserTest, marking for backport.

quietone opened merge request !16393

quietone’s picture

quietone commented

Tests are passing now, so this is ready.

quietone’s picture

quietone commented
Status: Patch (to be ported) » Needs review

11.x backport ready

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Tests are passing so assuming a good backport. Am making the assumption the MR was left in draft by accident btw.

  • longwave committed ab5bcf5c on 11.x 
    test: #3611749 Remove toolbar from tests where it is not needed

By:...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed ab5bcf5ccf7 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

quietone’s picture

quietone commented
Issue tags: -11.5.0 priority +11.5.0 release priority