Page broken when using 2 different themes

Good question. It looks complex to address. I'd welcome ideas.

+1
@Markus, thanks for your patch, I can too confirm that it works fine and as espected with editable field and views with Garland custom theme.

I can confirm this patch works for theme 'Pixture Reloaded' as well. Thanks!

patch also works for me using pixture_reloaded.

@markus_petrux: Thanks! I've assigned you CVS access. Please go ahead and apply this patch to HEAD. (There is no other branch yet.)

hi,

I'm using ajax_load module version 6.x-1.3 so it includes this patch already but my theme is still broken when using editablefield with views.

In my case, I'm using garland custom color theme as admin theme and another theme in front end. After the ajax_load, it changes the garland theme to another theme which causes break the admin page.

Please help.

From my understanding, seems it always loads the default theme which is front-end one?

After some tests I could confirm that ajax_load module is not working properly when you have 2 themes (one for admin and another for front end). The issue is that it replaces admin theme (css files) by the front end ones causing the site broken.

Steps to re-produce:

1. Having 2 themes, i'm using garland for admin, my custom theme for front end.

2. Using Views with editablefield in admin theme. You could set a test path like this: admin/test so that your page will use admin theme.

3. Run the path. The page is broken. Check the css files then you will see all are from the front end theme, not admin theme.

having a similar issue when using spaces / context since that will load in different CSS based on context. Why is it even loading CSS for the fields? Shouldn't it all be on the page anyway?

Similarly, i'm noticing an issue that seems related with page JS loading that I don't want to load or loading multiple times which sets events incorrectly in some instances.

i have also had this issue with color related modules, the patch is stable.

I had the same issue that came up when I installed editablefields and ajax_load.

ajax_load version used: 6.x-1.4

3 themes installed and enabled, and using 'sections' module to change theme based on path.

when I ajax_load is used by editablefields in a sections enabled theme, the default theme's css are loaded.

so I went through ajax_load.module and after commenting out this line of code, $data->css = $extra['css']; in ajax_load_ajax_data_alter(), everything came back to normal, without noticing anything going wrong in theme or functionality.

function ajax_load_ajax_data_alter(&$data) {
  $extra = ajax_data_get_data();
  $array = FALSE;
  // Detect whether the data being altered is an array.
  if (is_array($data)) {
    $data = (object) $data;
    $array = TRUE;
  }
  $data->scripts = $extra['scripts'];
  $data->css = $extra['css']; // <---------- comment out this line for a quick fix.
  if (!isset($data->__callbacks)) {
    $data->__callbacks = array();
  }
  // Set the AjaxLoad custom event as a callback.
  $data->__callbacks[] = 'Drupal.AjaxLoad.loadFiles';
  // Cast back to an array if necessary.
  if ($array) {
    $data = (array) $data;
  }
}

I did not investigate any further, as in how or why etc, cause i'm on a tight schedule.

Hope this helps.

Notice: Undefined index: logo in _color_page_alter() (line 114 of /var/www/modules/color/color.module).

There appears to still be an issue with 6.x-1.4 when the color module is in use with Garland (and probably other themes that use the color module) that causes a spammie watchdog notice. The _color_page_alter(&$vars) function normally receives a lot more $vars than ajax_load is providing. In particular it is missing the 'logo' index key which causes a notice on every (admin?) page load.

This can be easily fixed by defining something, anything, for the logo key. This may not be the exact proper fix but it does resolve the undefined index notice. For example, add $return['logo'] = null; to function ajax_data_get_data();

<?php
/**
 * Return an array of data representing the scripts and CSS files on a page.
 */
function ajax_data_get_data() {
  $return = array();
  $return['scripts'] = array();
  foreach (array('header', 'footer') as $scope) {
    $javascript = drupal_add_js(NULL, NULL, $scope);
    foreach ($javascript as $type => $data) {
      if (!$data) {
        unset($javascript[$type]);
      }
      elseif ($type == 'setting') {
        $javascript[$type] = call_user_func_array('array_merge_recursive', $data);
      }
    }
    $return['scripts'] = array_merge_recursive($return['scripts'], $javascript);
  }
  $return['css'] = drupal_add_css();
  $return['logo'] = null; // <-------- kinda hacky, but works

  // Allow the color.module alter the CSS array as if it was processed from
  // a regular page request. See phptemplate_preprocess_page() in garland.
  if (module_exists('color')) {
    init_theme();
    _color_page_alter($return);
  }

  // Deal with jQuery Update module, if exists.
  if (module_exists('jquery_update')) {
    ajax_load_jquery_update_preprocess($return);
  }

  return $return;
}
?>