Problem/Motivation

  1. core/.deprecation-ignore.txt
  2. core/themes/claro/css/base/elements.css
  3. core/themes/claro/css/base/elements.pcss.css
  4. core/themes/default_admin/css/base/elements.css
  5. core/themes/default_admin/css/base/elements.pcss.css
  6. core/themes/stable9/css/settings_tray/settings_tray.module.css
  7. core/themes/stable9/css/settings_tray/settings_tray.motion.css
  8. core/themes/stable9/css/settings_tray/settings_tray.theme.css
  9. core/themes/stable9/css/settings_tray/settings_tray.toolbar.css
  10. core/themes/stable9/stable9.info.yml

Steps to reproduce

Proposed resolution

Change these files

  1. core/themes/claro/css/base/elements.css
  2. core/themes/claro/css/base/elements.pcss.css
  3. core/themes/default_admin/css/base/elements.css
  4. core/themes/default_admin/css/base/elements.pcss.css

This will be updated when an extension is removed from core.

  1. core/.deprecation-ignore.txt

These stay and will go with stable9 to contrib when Stable9 is removed from core.

  1. core/themes/stable9/css/settings_tray/settings_tray.module.css
  2. core/themes/stable9/css/settings_tray/settings_tray.motion.css
  3. core/themes/stable9/css/settings_tray/settings_tray.theme.css
  4. core/themes/stable9/css/settings_tray/settings_tray.toolbar.css
  5. core/themes/stable9/stable9.info.yml

Remaining tasks

Review

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3611541

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !16345

quietone’s picture

quietone commented

What to do with these library overrides in stable9.info.yml?

  settings_tray/drupal.settings_tray:
    css:
      component:
        css/settings_tray.module.css: css/settings_tray/settings_tray.module.css
        css/settings_tray.motion.css: css/settings_tray/settings_tray.motion.css
        css/settings_tray.toolbar.css: css/settings_tray/settings_tray.toolbar.css
      theme:
        css/settings_tray.theme.css: css/settings_tray/settings_tray.theme.css
quietone’s picture

quietone commented
Issue tags: +11.5.0 release priority
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Not sure we need to do anything else here in 11.

The references in Stable9 can likely stay until we remove Stable9 itself from core, it's not really harming anything and Stable9 is supposed to be stable?

The references in .deprecation-ignore.txt, Claro and Default Admin can be removed when we remove Settings Tray from core.

quietone’s picture

quietone commented
Issue summary: View changes
Status: Active » Needs review

Thanks.

I've updated the issue summary and changing this to review for the removal of comments.

quietone’s picture

quietone commented
Issue summary: View changes

formatting

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Disclosure used AI because I suck with grepping "grep -rl "settings_tray" /Users/smustgrave/Sites/Drupal-Demos/drupal-11x/core \
--exclude-dir=settings_tray 2>/dev/null | head -10"

Which found

- core/.phpstan-baseline.php
- core/.deprecation-ignore.txt
- core/themes/stable9/stable9.info.yml

Summary mentioned phpstan and deprecation will be in the removal ticket.

Stable9 is already forked so should we open a follow up ticket over there?

  • catch committed 49f094e5 on 11.x 
    task: #3611541 Handle remaining uses of settings_tray not in the module...

  • catch committed 0ea01147 on main 
    task: #3611541 Handle remaining uses of settings_tray not in the module...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.