Visiting /admin/reports/dblog throws a fatal TypeError when autoban_dblog is enabled, on Drupal core 11.4.4. autoban_dblog's RouteSubscriber overrides dblog.overview's controller to AutobanDbLogController::overview but core's DbLogController::__construct() has been refactored — ModuleHandlerInterface was dropped, DbLogFilters added.

Once this fixed, there is still an issue with the module handler which is not available as a property anymore, throwng another error on the loadInclude() method call.

Issue fork autoban-3611400

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nicolasgraph created an issue. See original summary.

nicolasgraph opened merge request !15

nicolasgraph’s picture

nicolasgraph
Primary language French
Location Strasbourg
commented
Title: AutobanDbLogController::__construct() incompatible with core DbLogController signature » Fix D11.4+ support
Assigned: nicolasgraph » Unassigned
Issue summary: View changes
Status: Active » Needs review
nicolasgraph’s picture

nicolasgraph
Primary language French
Location Strasbourg
commented
Issue summary: View changes
nicolasgraph’s picture

nicolasgraph
Primary language French
Location Strasbourg
commented

The proposed fix should keep the module declared support.

maxtr2024’s picture

maxtr2024 commented

Thank you! The suggested fix helps the module work at full capacity.

niral098’s picture

niral098
Location NJ, United States
commented

The proposed changes works! No more fatal error.

goodboy’s picture

goodboy commented
Status: Needs review » Fixed

@nicolasgraph, thank you for the patch, merged
@maxtr2024 , niral098 - thanks for review

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.