Problem/Motivation

It's currently only possible to delete a sharepoint mapping by manually emptying all its configuration values, both for content type and webform modes. I noticed there are 2 delete routes present in sharepoint_connector.routing.yml, but they point to their respective edit forms. Also - they aren't actually used anywhere.

It would be nice if the "delete" option could be added to each sharepoint mapping, in the "operations" column.

Steps to reproduce

For webform sharepoint mappings:

  1. Navigate to /admin/config/sharepoint_connector/settings/webforms
  2. Add a sharepoint mapping for any webform
  3. Navigate back to /admin/config/sharepoint_connector/settings/webforms
  4. Only an edit link is available in the operations column, would be great if there was a dropdown where "Delete" is also available

Proposed resolution

Provide 2 delete forms that extend from ConfirmFormBase: one for sharepoint webform mapping, and one for sharepoint content type mapping. On delete confirmation, remove the entire sharepoint_connector.content_types.* config entry.

Issue fork sharepoint_connector-3609865

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

robindh created an issue. See original summary.

robindh opened merge request !7

robindh’s picture

robindh commented
Title: Provide easy sharepoint link delete functionality » Provide easy sharepoint mapping delete functionality
Assigned: robindh » Unassigned
Issue summary: View changes
Status: Active » Needs review

Added a merge request which supports this delete functionality via an extra link in the operations column, as described in the issue summary.

Also updating the issue description to use "mapping" instead of "link" for clarity

robbymo made their first commit to this issue’s fork.

robbymo’s picture

robbymo commented
Assigned: Unassigned » robbymo
Status: Needs review » Fixed

Thank you for the contribution, robindh! I have reviewed the updates and merged in the MR. This has been added into the latest version (1.0.7).

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.