Problem/Motivation

Follow up to #3583587: Convert some functional tests in system module to kernel tests

I have found 5 more tests in system module that can be converted. There are others that depend on #3566881: Add a submitForm() method to HttpKernelUiHelperTrait, but I'll open a separate issue so they can be postponed.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3609451

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mstrelan created an issue. See original summary.

mstrelan opened merge request !16262

mstrelan’s picture

mstrelan commented
Status: Active » Needs review

Fail is unrelated. Opened #3609454: Convert functional tests in system module with submitForm to kernel tests for the submitForm tests.

dcam’s picture

dcam commented
Status: Needs review » Needs work

The changes look good, but I did notice one thing that I had a question about. I left it in a comment on the MR.

dcam’s picture

dcam commented
Status: Needs work » Reviewed & tested by the community

The test that failed in both runs is in the list of known intermittent failures. But I ran it locally anyway and it passed.

Just for the sake of being thorough I checked the output of the Kernel test runs in the GitLab pipeline. All five moved tests are in the output. My feedback has been addressed and I didn't find anything else to comment about. This one looks good to me.

mstrelan’s picture

mstrelan commented

Thanks for the thorough review and for following through checking the pipelines. ConfigInstallProfileOverrideTest seems to be failing almost every time for me lately.

catch closed merge request !16262

  • catch committed a21084f0 on 11.x 
    task: #3609451 Convert more functional tests in system module to kernel...

  • catch committed f6f9977f on main 
    task: #3609451 Convert more functional tests in system module to kernel...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.