Problem/Motivation

Scanning this module with Upgrade Status produces warnings about missing return statements in the following methods:

  • RevisionOverviewController:buildRevertRevisionLink()
  • RevisionOverviewController:buildDeleteRevisionLink()
  • RevisionableContentEntityForm::save()
  • EnhancedEntityForm::save()

Steps to reproduce

scan the module with Upgrade Status in Drupal 11

Proposed resolution

Add return statements so the methods are consistent with their parents.

Remaining tasks

Make an MR. I'm assigning this to myself since I intend to work on it right away.

Issue fork entity-3609076

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

benstallings created an issue. See original summary.

benstallings opened merge request !48

benstallings’s picture

benstallings commented
Assigned: benstallings » Unassigned
Status: Active » Needs review
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Closed (duplicate)

Thanks, this was already fixed as part of #3615092: missing CacheableMetadata parameter adn PHPStan errors. Let me know if you still see issues!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.