Problem/Motivation

After enabling term_glossary_tippy, messages appear stating that files cannot be loaded.

Proposed resolution

I inspected the code and saw that the libraries "popperjs" and "tippyjs" were needed.
After downloading them - the module works.

Remaining tasks

Add at least a README.txt with download-links.

User interface changes

Throw warning if libraries are not found with link to README.txt

Issue fork term_glossary-3608664

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kle created an issue. See original summary.

mably made their first commit to this issue’s fork.

mably opened merge request !59

mably’s picture

mably commented
Title: term_glossary_tippy needs libraries » Warn when the Tippy.js external libraries are missing
Status: Active » Needs review

Thanks for the report. The download instructions were actually already in the main README.md (see the "Tippy.js plugin" section, shipped since 4.4.0), but nothing on the site pointed to them when the libraries were missing, so the module failed silently. The merge request adds the missing feedback:

  • A runtime requirements check on the status report page: missing libraries are reported as an error when the Tippy.js handler is the active integration type, as a warning otherwise, with the download links.
  • A warning message displayed immediately when the submodule is installed while the libraries are missing.
  • The same warning on the glossary configuration form, where the integration type is selected.
  • A README.md for the submodule with the library requirements, the expected file paths and the download links.
  • New suggest entries in composer.json for the npm-asset packages.
  • Unit and functional test coverage for the libraries check and the warnings.

I also retitled the issue to describe the change. Ready for review.

  • mably committed dae6a45f on 4.x 
    task: #3608664 Warn when the Tippy.js external libraries are missing

By...
mably’s picture

mably commented

@kle can you confirm it's ok to you?

mably’s picture

mably commented
Status: Needs review » Fixed

Merged into 4.x, will be part of the next release. Thanks for the report!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.