Problem/Motivation

Discovered via #3480051: Add return typehints to file test methods in \Drupal\Tests\rest\Functional\EntityResource\XmlEntityNormalizationQuirksTrait:

  protected function getExpectedNormalizedEntity() {

  protected function applyXmlConfigEntityDecodingQuirks(array $normalization) {

We should add return types here so eventually we can add them to the base class as well.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3608591

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave opened merge request !16225

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems straight forward. Bummer didn't touch any of the phpstan baseline.

godotislate closed merge request !16225

  • godotislate committed 2edb8ab9 on main 
    task: #3608591 Add return types to XmlEntityNormalizationQuirksTrait

By...

  • godotislate committed 06dfa45b on 11.x 
    task: #3608591 Add return types to XmlEntityNormalizationQuirksTrait

By...
godotislate’s picture

godotislate
he/him
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 2edb8ab to main and 06dfa45 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.