Spin off from #3399150: [PP-1] Enable dynamic queries to produce SQL with positional placeholders.

Problem/Motivation

\Drupal\Core\Database\ExceptionHandler methods only rethrow exceptions, but their return type is void.

This leads to static analysis issues and dead code.

Proposed resolution

Change return types to never.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3608491

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !16217

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

All code changes look good to me.
No new testing is needed.
For me it is RTBC.

catch closed merge request !16217

  • catch committed 9715af43 on main 
    fix: #3608491 \Drupal\Core\Database\ExceptionHandler methods never...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

This doesn't cherry-pick cleanly to 11.x, I think we can probably live with it only being in main so marking fixed, but also OK to backport to 11.x if we want to.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.