The example module is currently named orchestra_webform_example (singular) and sits at the top level of the project. Two things are off: it ships more than one example (two request-validation webforms and two workflows), and its sibling example module is already plural (orchestra_examples); and it is really an example of the Webform integration, so it belongs under that module. This issue renames it to orchestra_interaction_webform_examples and moves it to modules/orchestra_interaction_webform/modules/orchestra_interaction_webform_examples/, nested under the module it demonstrates.

The plural, parent-prefixed name matches the project's own nesting convention (in the related yoyaku project, yoyaku_orchestra_example nests under yoyaku_orchestra and inherits its prefix), so a submodule under orchestra_interaction_webform should read as orchestra_interaction_webform_examples rather than an orphaned orchestra_webform_example.

Scope

  • Rename the module: machine name, human-readable name, the .info.yml filename, the PHP test namespace (Drupal\Tests\orchestra_interaction_webform_examples), the dependency references in other modules' .info.yml, the shipped configs' dependencies.enforced.module, the interface-translation project and its .po path, and the docs references.
  • Move the directory to nest under orchestra_interaction_webform/modules/. A module's machine name comes from its .info.yml, not its path, so the move alone needs no migration; only the rename does.

Upgrade note

At this pre-release stage the module ships no update path. A site with the old module enabled must migrate it in place before the next cache rebuild, otherwise Drupal reports a missing module: rename the entry in core.extension, in the system.schema and locale.project key-value entries, and in the dependent config entities' stored dependencies. Because the old and new names differ in length, use a length-aware replace on the serialized values (the length prefix must be corrected, not just the string). A fresh install needs none of this.

Relationship to other issues

Independent of the delta-audit fixes in #3608117: Fix 1.0.0-alpha8 delta-audit findings: concurrency recovery races and webform branch-scoping and the recovery-layer refactor in #3608146: Refactor the state-transition and recovery layer: one guarded transition primitive and unified stuck-instance sweeps; it touches only the example module and references to it.

Issue fork orchestra-3608148

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mably created an issue. See original summary.

mably’s picture

Status: Active » Needs review

  • mably committed ee305dac on 1.x
    task: #3608148 Rename orchestra_webform_example to...
mably’s picture

Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.