Follow-up to #3607508 (the Easy Email channel).
orchestra_webform_example declares a hard dependency on orchestra_mail in its info file, because its MailHook (a hook_mail_alter) supplies the wording for the example's request_processed and request_rejected notification types. But notifications are channel-agnostic, so the example should not require one specific channel. The coupling has a real cost: uninstalling orchestra_mail cascades and uninstalls the example, deleting its workflows and purging running instances.
Fix
- Drop the
orchestra_maildependency fromorchestra_webform_example. - Make the
orchestra_mail-specificMailHooka no-op (or not fire) whenorchestra_mailis not installed, so it stays an optional enhancement rather than a requirement. - Ship
request_processedandrequest_rejectedcontent for the Easy Email channel too:easy_email.easy_email_type.orchestra_request_processedandorchestra_request_rejected(provided by the example, or by an example-specific glue), so the example works whichever channel is enabled.
Result: either channel (Orchestra Mail or Orchestra Easy Email) works with the example, and neither is mandatory, so a site can run the example on Easy Email alone.
Issue fork orchestra-3607617
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
mably commentedComment #5
mably commented