Problem/Motivation

The 5.x branch is not passing on the next minor or max PHP let's fix it.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

alexpott created an issue. See original summary.

alexpott’s picture

Title: Fix 5.x branch on next minor and max PHP » 11.4.x system updates need to happen after entity usage config update
alexpott’s picture

Status: Active » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Actually I want to make the code a bit more robust and just ignore the old format. Just in case other updates cause the same problem

alexpott’s picture

Status: Needs work » Reviewed & tested by the community

This is the first step to automating discovery of the site's url - now we've got all the internal checking happening in the new SiteDomain class. This means that we can then inject the RequestContext and use \Drupal\Core\Routing\RequestContext::getCompleteBaseUrl() to add that automatically. We can also add the public streamwrapper and automatically add that's external URL too. That would cover things like S3 storage where files are stored on a different URL.

  • alexpott committed 8a45b3c9 on 5.x
    fix: #3607113 11.4.x system updates need to happen after entity usage...
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.